Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge translations from past 3 weeks #2801

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix: merge translations from past 3 weeks #2801

merged 9 commits into from
Nov 6, 2023

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Oct 23, 2023

In this PR:

  • translations (makes this merge a 'fix' rather than a 'chore')
  • fixes to cypress due to inconsistent return status codes from api (getting both 200 and 201)
  • clean up cypress folder
  • adds a release-failure slackbot message

dhis2-bot and others added 7 commits September 14, 2023 03:32
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 23, 2023

🚀 Deployed on https://pr-2801--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 23, 2023 08:05 Inactive
…sts (#2802)

Needed to keep the cypress tests passing.

There is a recurring issue from the backend:
Sometimes a create request returns 200, other times 201.
To avoid having to update these tests continually, accept both values as valid
since it doesn't have any impact on the app
@dhis2-bot dhis2-bot temporarily deployed to netlify October 24, 2023 07:52 Inactive
@cypress
Copy link

cypress bot commented Oct 24, 2023

Passing run #4280 ↗︎

0 52 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix(translations): sync translations from transifex (dev)
Project: dashboards-app Commit: 9ebfa9f063
Status: Passed Duration: 10:18 💡
Started: Oct 29, 2023 1:39 AM Ended: Oct 29, 2023 1:49 AM

Review all test suite changes for PR #2801 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify October 29, 2023 01:37 Inactive
Copy link
Collaborator

@janhenrikoverland janhenrikoverland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if tests pass.

@jenniferarnesen jenniferarnesen merged commit 3e9aecf into master Nov 6, 2023
77 of 83 checks passed
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants