-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [DHIS2-15685][DHIS2-18326] View an event without selecting org unit in Tracker Programs #3926
base: master
Are you sure you want to change the base?
fix: [DHIS2-15685][DHIS2-18326] View an event without selecting org unit in Tracker Programs #3926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henrikmv,
After this bug fix, I have two suggestions to improve some existing related functionality.
Firstly, in event edit mode, make some changes to the form, and then when deselecting the org unit, the "Discard unsaved changes" dialog will be displayed. Is this dialog still relevant, as now the page should be visible without an org unit and the unsaved data is not discarded from the form?
Secondly, in an event program, when deselecting the org unit, the user is redirected to the home page. Does it make sense to remove this redirect and keep the user on the same page while the event view/edit form is displayed?
Any thoughts on these suggestions? Thanks!
After discussion with @JoakimSM, DHIS2-15685 now only affects Tracker programs. A new ticket will be created for Event programs. |
src/core_modules/capture-core/components/ScopeSelector/ScopeSelector.component.js
Outdated
Show resolved
Hide resolved
…viewingEventShouldBePossibleWithoutSelectingOrgUnit
…sibleWithoutSelectingOrgUnit
Quality Gate passedIssues Measures |
DHIS2-15685 and DHIS2-18236:
This issue is blocked by DHIS2-18325 and DHIS2-18664`.