Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-18329] Add org unit selector in schedule event form #3925

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Jan 2, 2025

DHIS2-18329:

  • Implemented org. unit selector in Schedule tab
  • Modify the Infobox

@henrikmv henrikmv marked this pull request as ready for review January 2, 2025 13:14
@henrikmv henrikmv requested a review from a team as a code owner January 2, 2025 13:14
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @henrikmv,
Great start for this feature👏 ! I like that you used the existing folder structure from the existing DataEntries.
In addition to the code comments, I was wondering how this feature will work once DHIS2-15685 is merged. Can the user reschedule an event without having an org unit selected in ScopeSelector?
Thank you!

Copy link

github-actions bot commented Jan 9, 2025

@henrikmv henrikmv added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud and removed testing e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels Jan 9, 2025
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants