-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-18329] Add org unit selector in schedule event form #3925
base: master
Are you sure you want to change the base?
feat: [DHIS2-18329] Add org unit selector in schedule event form #3925
Conversation
…_ShowOrgUnitSelectorInScheduleEventForm
…_ShowOrgUnitSelectorInScheduleEventForm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henrikmv,
Great start for this feature👏 ! I like that you used the existing folder structure from the existing DataEntries.
In addition to the code comments, I was wondering how this feature will work once DHIS2-15685 is merged. Can the user reschedule an event without having an org unit selected in ScopeSelector?
Thank you!
...e_modules/capture-core/components/WidgetEventSchedule/ScheduleDate/ScheduleDate.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.container.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/widgetEventSchedule.types.js
Outdated
Show resolved
Hide resolved
🚀 Deployed on https://deploy-preview-3925.capture.netlify.dhis2.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…_ShowOrgUnitSelectorInScheduleEventForm
DHIS2-18329:
Schedule tab
Infobox