chore: remove todos #891
Merged
chore: remove todos #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabaros
commented
Nov 7, 2024
| @@ -109,7 +109,7 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => { | |||
| './.d2/shell/src/plugin.index.jsx' | |||
| ), | |||
| shellPluginEntrypoint: path.join(base, './.d2/shell/src/Plugin.jsx'), | |||
| // TODO: look at what to do with service-worker files whether to move to TS or not | |||
|
|
|||
There was a problem hiding this comment.
removed this todo - it's a general question about whether we should move this whole repo to TypeScript, not the place for it in this PR
kabaros
commented
Nov 7, 2024
| @@ -85,7 +85,7 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => { | |||
| package: path.join(base, './package.json'), | |||
| yarnLock: findYarnLock(base, rootDirectory), | |||
| dotenv: path.join(base, './.env'), | |||
| config: path.join(base, './d2.config.js'), // TODO: double check this works | |||
| config: path.join(base, './d2.config.js'), | |||
kabaros
commented
Nov 7, 2024
| @@ -61,7 +61,6 @@ const handler = async ({ | |||
| pack: packAppOutput, | |||
| allowJsxInJs, | |||
| }) => { | |||
| // todo: we need to infer TypeScript in build command here similar to start | |||
| const paths = makePaths(cwd) | |||
There was a problem hiding this comment.
checked the build command works
|
🎉 This PR is included in version 12.0.0-alpha.23 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.