chore: remove todos (#891)

* chore: remove todos * chore: yarn --------- Co-authored-by: Kai Vandivier <[email protected]>
dhis2 · Nov 7, 2024 · e123d22 · e123d22
1 parent 4543f45
commit e123d22
Show file tree

Hide file tree

Showing 3 changed files with 573 additions and 774 deletions.
diff --git a/cli/src/commands/build.js b/cli/src/commands/build.js
@@ -61,7 +61,6 @@ const handler = async ({
     pack: packAppOutput,
     allowJsxInJs,
 }) => {
-    // todo: we need to infer TypeScript in build command here similar to start
     const paths = makePaths(cwd)
 
     mode = mode || (dev && 'development') || getNodeEnv() || 'production'

diff --git a/cli/src/lib/paths.js b/cli/src/lib/paths.js
@@ -85,7 +85,7 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => {
         package: path.join(base, './package.json'),
         yarnLock: findYarnLock(base, rootDirectory),
         dotenv: path.join(base, './.env'),
-        config: path.join(base, './d2.config.js'), // TODO: double check this works
+        config: path.join(base, './d2.config.js'),
         readme: path.join(base, './README.md'),
         src: path.join(base, './src'),
         public: path.join(base, './public'),
@@ -109,7 +109,7 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => {
             './.d2/shell/src/plugin.index.jsx'
         ),
         shellPluginEntrypoint: path.join(base, './.d2/shell/src/Plugin.jsx'),
-        // TODO: look at what to do with service-worker files whether to move to TS or not
+
         shellSrcServiceWorker: path.join(
             base,
             './.d2/shell/src/service-worker.js'