Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with outputs in scaffolding and improve scaffolding documentation #76

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Fix bug with outputs in scaffolding and improve scaffolding documentation #76

merged 4 commits into from
Jan 18, 2024

Conversation

avnes
Copy link
Contributor

@avnes avnes commented Jan 18, 2024

  • Make scaffold docs more generic for docker run
  • Fix markdown lints and enhance the scaffolding instructions
  • Add missing ssh executable
  • Rename output variable in scaffolding to fit module name

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have tested changes in my sandbox
  • I have added the needed changes in the test/qa folder to apply my changes in QA.
  • I have rebased the code to main (or merged in the latest from main)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@avnes avnes added the release:minor Semantic versioning minor release label label Jan 18, 2024
@avnes avnes merged commit e4224a6 into main Jan 18, 2024
7 checks passed
@avnes avnes deleted the bugfix/cloudplatform-2480 branch January 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samidbb samidbb samidbb approved these changes

Assignees
No one assigned
Labels
release:minor Semantic versioning minor release label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avnes @samidbb