Merge pull request #76 from dfds/bugfix/cloudplatform-2480

Fix bug with outputs in scaffolding and improve scaffolding documentation

tools/Dockerfile

@@ -1,7 +1,7 @@
 FROM python:slim
 
 RUN apt update && \
-    apt install -y curl libpq-dev less jq tar unzip
+    apt install -y curl libpq-dev less jq tar unzip ssh
 
 
 # Adding  GitHub public SSH key to known hosts

tools/README.md

@@ -1,6 +1,14 @@
-Run docker file:
+# Scaffolding guide
 
+Change directory to where you have <https://github.com/dfds/terraform-aws-rds> checked out.
+
+```bash
 cd /dfds/terraform-aws-rds/tools
+```
+
+## Build container image and create required directory
+
+Build the container image:
 
 ```bash
 docker build -t scaffold .
@@ -12,8 +20,11 @@ Create output folder:
 mkdir auto-generated
 ```
 
-Run docker:
+## Run container
+
+Run newly created image:
 
 ```bash
-docker run -v <absolute-path>/terraform-aws-rds/:/input -v <absolute-path>/terraform-aws-rds/tools/auto-generated/:/output scaffold:latest
+cd ../..
+docker run -v $PWD/terraform-aws-rds/:/input -v $PWD/terraform-aws-rds/tools/auto-generated/:/output scaffold:latest
 ```

tools/scaffolding/scripts/generate_tf_module.py

@@ -31,7 +31,7 @@
 output_list = []
 OUTPUT_TEMPLATE = """output "$out_name" {
   description = "$output_description"
-  value       = try(module.db_instance_example.$out_value, null)
+  value       = try(module.db_instance.$out_value, null)
 }"""
 
 with open(work_folder, "r", encoding='UTF-8') as f: