chore: open shouldStopPropagation prop for DeleteDialog

devtron-labs · Nov 21, 2023 · 6ca9c44 · 6ca9c44
1 parent 4ff6b01
commit 6ca9c44
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.0.40-beta-14",
+    "version": "0.0.40-beta-15",
     "description": "Supporting common component library",
     "main": "dist/index.js",
     "scripts": {

diff --git a/src/Common/Dialogs/DeleteDialog.tsx b/src/Common/Dialogs/DeleteDialog.tsx
@@ -6,12 +6,18 @@ import { DeleteDialogProps } from './Types'
 
 export const DeleteDialog: React.FC<DeleteDialogProps> & { Description?: React.FC<any> } = function (props) {
     const handleDelete = (e: React.MouseEvent) => {
-        e.stopPropagation()
+        if (props.shouldStopPropagation) {
+            e.stopPropagation()
+        }
+
         props.delete()
     }
 
     const handleModalClose = (e: React.MouseEvent) => {
-        e.stopPropagation()
+        if (props.shouldStopPropagation) {
+            e.stopPropagation()
+        }
+
         props.closeDelete()
     }
 

diff --git a/src/Common/Dialogs/Types.ts b/src/Common/Dialogs/Types.ts
@@ -10,6 +10,7 @@ export interface DeleteDialogProps {
     apiCallInProgress?: boolean
     dataTestId?: string
     buttonPrimaryText?: string
+    shouldStopPropagation?: boolean
 }
 
 export interface ForceDeleteDialogType {