chore: revert exposing e

devtron-labs · Nov 21, 2023 · 4ff6b01 · 4ff6b01
1 parent 4c0ee0a
commit 4ff6b01
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.0.40-beta-13",
+    "version": "0.0.40-beta-14",
     "description": "Supporting common component library",
     "main": "dist/index.js",
     "scripts": {

diff --git a/src/Common/Dialogs/DeleteDialog.tsx b/src/Common/Dialogs/DeleteDialog.tsx
@@ -5,6 +5,16 @@ import ConfirmationDialog from './ConfirmationDialog'
 import { DeleteDialogProps } from './Types'
 
 export const DeleteDialog: React.FC<DeleteDialogProps> & { Description?: React.FC<any> } = function (props) {
+    const handleDelete = (e: React.MouseEvent) => {
+        e.stopPropagation()
+        props.delete()
+    }
+
+    const handleModalClose = (e: React.MouseEvent) => {
+        e.stopPropagation()
+        props.closeDelete()
+    }
+
     return (
         <ConfirmationDialog className="confirmation-dialog__body--w-400">
             <ConfirmationDialog.Icon src={warn} />
@@ -19,7 +29,7 @@ export const DeleteDialog: React.FC<DeleteDialogProps> & { Description?: React.F
                     <button
                         type="button"
                         className="cta cancel cta-cd-delete-modal ml-16"
-                        onClick={props.closeDelete}
+                        onClick={handleModalClose}
                         disabled={props.apiCallInProgress}
                         data-testid="dialog-cancel"
                     >
@@ -28,7 +38,7 @@ export const DeleteDialog: React.FC<DeleteDialogProps> & { Description?: React.F
                     <button
                         type="button"
                         className="cta delete cta-cd-delete-modal ml-16"
-                        onClick={props.delete}
+                        onClick={handleDelete}
                         disabled={props.apiCallInProgress}
                         data-testid="dialog-delete"
                     >

diff --git a/src/Common/Dialogs/Types.ts b/src/Common/Dialogs/Types.ts
@@ -3,8 +3,8 @@ import { ReactNode } from "react"
 export interface DeleteDialogProps {
     title: string
     description?: string
-    closeDelete: (e?: React.MouseEvent) => void
-    delete: (e?: React.MouseEvent) => any
+    closeDelete: () => void
+    delete: () => any
     deletePrefix?: string
     deletePostfix?: string
     apiCallInProgress?: boolean