Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): select icon clickable #1133

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

bar-tay
Copy link
Contributor

@bar-tay bar-tay commented Jul 2, 2024

No description provided.

@bar-tay bar-tay force-pushed the fix/1114_select-adjust-menu-placement branch from 4afa538 to a120085 Compare July 9, 2024 14:20
@bar-tay bar-tay requested a review from angsherpa456 July 9, 2024 14:50
@bar-tay bar-tay added the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Jul 9, 2024
@bar-tay bar-tay linked an issue Jul 9, 2024 that may be closed by this pull request
5 tasks
@thrbnhrtmnn
Copy link
Contributor

Hey @bar-tay ,

here are my findings from the review:

  • The icon is still shown, even if icon = undefined
  • Would it be possible to increase the clickable area of the select so a user can click everywhere inside the outlined area and the menu opens?

@thrbnhrtmnn thrbnhrtmnn self-assigned this Jul 10, 2024
@thrbnhrtmnn thrbnhrtmnn removed the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Jul 10, 2024
@thrbnhrtmnn thrbnhrtmnn removed their assignment Jul 10, 2024
@thrbnhrtmnn thrbnhrtmnn self-requested a review July 10, 2024 12:53
@bar-tay bar-tay changed the title feat(storybook): wip feat(storybook): select icon clickable Jul 11, 2024
@thrbnhrtmnn
Copy link
Contributor

Hey @bar-tay ,
thanks for the update, this looks good now.

As discussed, lets change 2 minor things:

  1. change the default option to the first in the array
  2. change the storybook setting, so the parent container is the same as the one we use for input field text & number (using the whole width of the viewport)

@thrbnhrtmnn thrbnhrtmnn merged commit 60e24e3 into develop Jul 31, 2024
4 of 5 checks passed
@thrbnhrtmnn thrbnhrtmnn deleted the fix/1114_select-adjust-menu-placement branch July 31, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select - adjust native menu placement and opening and fix undefined icon
4 participants