Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - adjust native menu placement and opening and fix undefined icon #1114

Closed
5 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Jun 7, 2024 · 0 comments · Fixed by #1133
Closed
5 tasks done
Tracked by #452

Select - adjust native menu placement and opening and fix undefined icon #1114

thrbnhrtmnn opened this issue Jun 7, 2024 · 0 comments · Fixed by #1133
Assignees
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jun 7, 2024

Description / User story

The select should be closely aligned in design and code.

  • For this the native menu placement in code should ideally be exactly as in design.
  • Additionally one improvement of the select would be if the native menu opens no matter where a user clicks in the input field. Currently in code it only opens when you click on the text. Most importantly the menu should also be shown when a user clicks on the icon. Ideally we find a similar solution to how it is done in the text area, where clicking anywhere within the input field allows for an input to be made.
  • Furthermore the menu should also open select should be focused when you click on the label similar to how it works for text area and input field text.
  • Lastly if icon = undefined we still show an icon in code. This should be fixed so we do not show an icon in this case.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • The native menu is placed in the coded component similar to how it is shown in design
  • The native menu opens, when a user clicks on the icon (even better, if possible: The native menu opens when a user clicks anywhere in the input field)
  • The native menu opens gets focused, when a user clicks on the label (even better, if possible: also the gap between label and input field is clickable)
  • If icon = undefined, no icon is shown in the input field

Additional information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors good first issue Good for newcomers ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Jun 7, 2024
@bar-tay bar-tay self-assigned this Jun 21, 2024
@bar-tay bar-tay linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers 🎓 junior issue Good for juniors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants