Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): support expect.addSnapshotSerializer #6173

Merged
merged 8 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions expect/_serializer.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.

import type { SnapshotPlugin } from "./_types.ts";

const INTERNAL_PLUGINS: SnapshotPlugin[] = [
// TODO(eryue0220): support internal snapshot serializer plugins
];

export function addSerializer(plugin: SnapshotPlugin) {
INTERNAL_PLUGINS.unshift(plugin);
}

export function getSerializer() {
return INTERNAL_PLUGINS;
}
23 changes: 23 additions & 0 deletions expect/_serializer_test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.

import { expect } from "./expect.ts";
import { addSerializer, getSerializer } from "./_serializer.ts";
import type { SnapshotPlugin } from "./_types.ts";

const foo: SnapshotPlugin = {
serialize() {
return "foot";
},
test() {
return false;
},
};

Deno.test("initial serializer", () => {
expect(getSerializer()).toHaveLength(0);
});

Deno.test("add serializer", () => {
addSerializer(foo);
expect(getSerializer()).toHaveLength(1);
});
2 changes: 2 additions & 0 deletions expect/_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -915,3 +915,5 @@ export interface OldSnapshotPlugin {
) => string;
test: Test;
}

export type SnapshotPlugin = NewSnapshotPlugin | OldSnapshotPlugin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is OldSnapshotPlugin still common? How about only supporting NewSnapshotPlugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I checked some serialize plugins, they still use OldSnapshottPlugin type definition, like:

jest-serializer-vue
jest-serializer-html
jest-serializer-react-helmet
jest-snapshot-serializer-ansi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

21 changes: 20 additions & 1 deletion expect/expect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ import {
toStrictEqual,
toThrow,
} from "./_matchers.ts";
import { addSerializer } from "./_serializer.ts";
import { isPromiseLike } from "./_utils.ts";
import * as asymmetricMatchers from "./_asymmetric_matchers.ts";
import type { Tester } from "./_types.ts";
import type { SnapshotPlugin, Tester } from "./_types.ts";

export type { AnyConstructor, Async, Expected } from "./_types.ts";

Expand Down Expand Up @@ -599,3 +600,21 @@ expect.not = {
stringContaining: asymmetricMatchers.stringNotContaining,
stringMatching: asymmetricMatchers.stringNotMatching,
};
/**
* `expect.addSnapshotSerializer` adds a module that formats application-specific data structures.
*
* For an individual test file, an added module precedes any modules from snapshotSerializers configuration,
* which precede the default snapshot serializers for built-in JavaScript types and for React elements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing for React elements part as that phrase feels strange in this repo.

* The last module added is the first module tested.
*
* @example
* ```ts no-eval
* import { expect } from "@std/expect";
* import serializerAnsi from "npm:jest-snapshot-serializer-ansi";
*
* expect.addSnapshotSerializer(serializerAnsi);
* ```
*/
expect.addSnapshotSerializer = addSerializer as (
plugin: SnapshotPlugin,
) => void;
3 changes: 1 addition & 2 deletions expect/mod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
* - {@linkcode expect.stringMatching}
* - {@linkcode expect.not.stringMatching}
* - Utilities:
* - {@linkcode expect.addSnapshotSerializer}
* - {@linkcode expect.assertions}
* - {@linkcode expect.addEqualityTester}
* - {@linkcode expect.extend}
Expand All @@ -74,8 +75,6 @@
* - `toMatchInlineSnapshot`
* - `toThrowErrorMatchingSnapshot`
* - `toThrowErrorMatchingInlineSnapshot`
* - Utilities:
* - `expect.addSnapshotSerializer`
*
* The tracking issue to add support for unsupported parts of the API is
* {@link https://github.com/denoland/std/issues/3964}.
Expand Down