fix(expect): support expect.addSnapshotSerializer
#6173
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error about typo checking has submitted in this pr #6171. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
==========================================
+ Coverage 96.49% 96.51% +0.02%
==========================================
Files 538 539 +1
Lines 40969 41289 +320
Branches 6162 6160 -2
==========================================
+ Hits 39531 39851 +320
Misses 1394 1394
Partials 44 44 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
Nov 5, 2024
expect/expect.ts
Outdated
| * `expect.addSnapshotSerializer` adds a module that formats application-specific data structures. | ||
| * | ||
| * For an individual test file, an added module precedes any modules from snapshotSerializers configuration, | ||
| * which precede the default snapshot serializers for built-in JavaScript types and for React elements. |
There was a problem hiding this comment.
I'm removing for React elements part as that phrase feels strange in this repo.
kt3k
reviewed
Nov 5, 2024
| @@ -915,3 +915,5 @@ export interface OldSnapshotPlugin { | |||
| ) => string; | |||
| test: Test; | |||
| } | |||
|
|
|||
| export type SnapshotPlugin = NewSnapshotPlugin | OldSnapshotPlugin; | |||
There was a problem hiding this comment.
Is OldSnapshotPlugin still common? How about only supporting NewSnapshotPlugin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3964, support
expect.addSnapshotSerializerapi.