Feat/build with poetry #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLKRo
reviewed
May 23, 2023
# Conflicts: # setup.py
This requires the `wrapt` library which I haven't specified yet in project requirements.
Added wrapt dependency as a core dependency Added urllib3 dependency to core (poetry requires urllib3<2.0 to function but some extra libraries update its version) Maybe should use a different approach for these dependencies (not install them in core)
- Add pip upgrade for no reason - Install specific extras instead of all - Add flags to fix problems with poetry install - Temporary fix of coverage job (poetry run test doesn't work)
|
Help needed with following lines of patch_source_file(
getsourcefile(sphinx_autodoc_typehints),
"""
class LoggerDummy():
def warning(self, message, *args):
print(f"Warning suppressed: {message % args}")
_LOGGER = LoggerDummy()
""",
) |
# Conflicts: # dff/__init__.py # docs/source/conf.py # makefile # setup.py
Instead of removing all directories to check that tests pass and do not miss any json files in `dff` it would be better to simply include all files under `dff` into source package. Also remove redundant excludes and includes.
These are separate tasks.
|
Should we exclude |
|
Do you mean from |
Coverage 7.3.3 breaks `pragma: no cover` -- https://www.github.com/nedbat/coveragepy/issues/1713
The error with test_coverage was caused by new `coverage` version breaking things. Keeping poetry lock in git would allow to separate errors caused by our code from those caused by dependency updates: https://python-poetry.org/docs/basic-usage/#committing-your-poetrylock-file-to-version-control
All devel processes require it.
RLKRo
approved these changes
Dec 14, 2023
Poetry lock allows us to freeze dependencies without doing so in pyproject.toml.
RLKRo
approved these changes
Dec 15, 2023
urllib breaks poetry, so we want to restrict its version only in devel environments
|
Merging this PR will make dependabot notify us only about new versions of |
|
@pseusys |
pseusys
commented
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building with
poetryadded.Checklist