Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes (mostly cosmetics) #71

Closed
wants to merge 6 commits into from
Closed

Various fixes (mostly cosmetics) #71

wants to merge 6 commits into from

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented Jan 23, 2023

Description

  1. GitHub Action conditions fixed: now build_and_publish_docs is run on docs/ prefixed branches and codestyle runs on all branches
  2. Fixes [BUG] Lint skipping #68 (partly, only flake8). I couldn't think of a proper regex for black's --exclude.

Checklist

  • I have covered the code with tests
  • I have added comments to my code to help others understand it
  • I have updated the documentation to reflect the changes
  • I have performed a self-review of the changes

@pseusys pseusys added enhancement New feature or request help wanted Extra attention is needed labels Jan 23, 2023
@pseusys pseusys requested a review from RLKRo January 23, 2023 21:12
@pseusys pseusys self-assigned this Jan 23, 2023
@pseusys pseusys requested a review from kudep February 5, 2023 22:01
@pseusys
Copy link
Collaborator Author

pseusys commented Feb 10, 2023

Setting black option to --exclude='/venv/|/build/|/examples/' doesn't resolve the issue with tests/examples/test_utils.py file!

@pseusys pseusys requested a review from RLKRo February 10, 2023 22:08
@pseusys pseusys mentioned this pull request Mar 20, 2023
Merged
4 tasks
@kudep
Copy link
Collaborator

kudep commented Jun 22, 2023 •
edited
Loading

waiting #132

@RLKRo RLKRo closed this Jan 10, 2024
@RLKRo
Copy link
Member

RLKRo commented Jan 10, 2024

I don't see much sense in the first change -- all workflows run on all PRs into dev or master.
Second change is superseded in #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kudep kudep Awaiting requested review from kudep

@RLKRo RLKRo Awaiting requested review from RLKRo

Assignees

@pseusys pseusys

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Lint skipping
3 participants
@pseusys @kudep @RLKRo