Add test for tags #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/assets/data/clinc_subset.json
voorhs
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
уф что-то сейчас в нампаевских операциях разобраться тяжело (конец дня)
если этот файл очень нужно поревьюить то скажи, завтра сделаю
tests/assets/data/clinc_subset.json
Outdated
There was a problem hiding this comment.
Хммм а ты кажется поменял логику разметки тегами. Раньше она была такая: допустим есть интенты to_right, to_left --- их логично пометить одним тегом direction, чтобы предсказывался всегда только один интент из них.
А ты видимо при добавлении нового интента указываешь интенты, с которыми этот интент не должен предсказываться. Я пока не знаю насколько это лучше, но если что завтра еще раз обсудим
voorhs
reviewed
Dec 6, 2024
| @@ -8,7 +8,7 @@ | |||
| def test_multiclass(multiclass_fit_data): | |||
| predictor = ArgmaxPredictor() | |||
| predictor.fit(*multiclass_fit_data) | |||
| scores = np.array([[0.1, 0.9, 0, 0.1], [0.8, 0, 0.2, 0.5], [0, 0.3, 0.7, 0.1]]) | |||
| scores = np.array([[0.1, 0.9, 0, 0.1], [0.8, 0, 0.1, 0.1], [0, 0.2, 0.7, 0.1]]) | |||
There was a problem hiding this comment.
еще пропустил 0.1, 0.9, 0, 0.1
voorhs
reviewed
Dec 6, 2024
| @@ -21,7 +21,7 @@ def detect_oos(scores: npt.NDArray[Any], labels: npt.NDArray[Any], thresh: float | |||
| def test_predict_returns_correct_indices(multiclass_fit_data): | |||
| predictor = JinoosPredictor() | |||
| predictor.fit(*multiclass_fit_data) | |||
| scores = np.array([[0.1, 0.9, 0, 0.1], [0.8, 0, 0.2, 0.5], [0, 0.3, 0.7, 0.1]]) | |||
| scores = np.array([[0.1, 0.9, 0, 0.1], [0.8, 0, 0.1, 0.1], [0, 0.2, 0.7, 0.1]]) | |||
voorhs
reviewed
Dec 6, 2024
voorhs
reviewed
Dec 6, 2024
voorhs
reviewed
Dec 6, 2024
voorhs
reviewed
Dec 6, 2024
voorhs
approved these changes
Dec 6, 2024
voorhs
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.