Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intel-SIG] MTL platform driver updates sync with upstream (6.9) #248

Merged

Conversation

quanxianwang
Copy link
Contributor

#patchset-ac2d1fd9688f-- 0014
ac2d1fd,platform/x86/intel/pmc/arl: Put GNA device in D3,2024-03-12 12:47:53 +0200,David E. Box [email protected],v6.9-rc1
e6ba4ac,platform/x86/intel/pmc/lnl: Remove SSRAM support,2024-03-12 12:47:51 +0200,David E. Box [email protected],v6.9-rc1
6f9fac5,platform/x86/intel/pmc/lnl: Add GBE LTR ignore during suspend,2024-01-02 13:26:28 +0100,David E. Box [email protected],v6.8
701d40a,platform/x86/intel/vsec: Remove nuisance message,2024-03-12 12:47:49 +0200,David E. Box [email protected],v6.9-rc1

debox1 added 4 commits May 30, 2024 12:55
mainline:701d40af59373ac3a60c620cbd0ceff7b2b8e565
severity: Moderate

upstream commit 701d40a ("platform/x86/intel/vsec: Remove nuisance message")

intel_vsec_walk_header() is used to configure features from devices that
don't provide a PCI VSEC or DVSEC structure. Some of these features may
be unsupported and fail to load. Ignore them silently as we do for
unsupported features described by VSEC/DVSEC.

Intel-SIG: commit 701d40a ("platform/x86/intel/vsec: Remove nuisance message")

Signed-off-by: "David E. Box" <[email protected]>
Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Ilpo Järvinen <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
mainline:6f9fac5535ba2038063c656f0afb496d7f87bcc1
severity: Moderate

upstream commit 6f9fac5 ("platform/x86/intel/pmc/lnl: Add GBE LTR ignore during suspend")

Add the GBE LTR ignore suspend time fix for Lunar Lake.

Fixes: 119652b855e6 ("platform/x86/intel/pmc: Add Lunar Lake M support to intel_pmc_core driver")

Intel-SIG: commit 6f9fac5 ("platform/x86/intel/pmc/lnl: Add GBE LTR ignore during suspend")

Signed-off-by: David E. Box <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Hans de Goede <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
mainline:e6ba4acde44957dc9bdc3222b5739217a102752d
severity: Moderate

upstream commit e6ba4ac ("platform/x86/intel/pmc/lnl: Remove SSRAM support")

A recent PMC firmware change in Lunar Lake caused the pmc_core driver to
fail to probe. This is due to a change in the GUID for PMC telemetry coming
from the SSRAM device. Until a final release is ready this value may
change again. In the meantime, disable the SSRAM support for Lunar Lake so
the driver can load and provide some basic functionality.

Fixes: 3748dfd ("platform/x86/intel/pmc: Add Lunar Lake M support to intel_pmc_core driver")

Intel-SIG: commit e6ba4ac ("platform/x86/intel/pmc/lnl: Remove SSRAM support")

Signed-off-by: "David E. Box" <[email protected]>
Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Ilpo Järvinen <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
mainline:ac2d1fd9688fcdfba5acc815fb2b13fec83e5dad
severity: Moderate

upstream commit ac2d1fd ("platform/x86/intel/pmc/arl: Put GNA device in D3")

As is the case on Meteor Lake, the Gaussian & Neural Accelerator (GNA)
device is powered by BIOS to D0 by default. If no driver is loaded, this
will cause the Package C state to be limited to PC2, leading to
significant power consumption and decrease in batter life.  Put the GNA
device in D3 by default if no driver is loaded for it.

Fixes: 83f168a ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver")

Intel-SIG: commit ac2d1fd ("platform/x86/intel/pmc/arl: Put GNA device in D3")

Signed-off-by: "David E. Box" <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Ilpo Järvinen <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yukarichiba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • arl_d3_fixup函数中新增了pmc_core_set_device_d3(ARL_GNA_PCI_DEV);调用,但未看到对应设备ARL_GNA_PCI_DEV的定义或说明,可能会导致编译错误或未定义行为。
  • lnl_resume函数中新增了pmc_core_send_ltr_ignore(pmcdev, 3, 0);调用,但未在函数体内看到对pmcdev的初始化操作,可能会导致运行时错误。
  • pmcdev->suspend被设置为cnl_suspend,但未看到cnl_suspend的定义或说明,可能会导致编译错误或未定义行为。
  • lnl_core_init函数中,pmc->map被直接赋值为&lnl_socm_reg_map,但没有看到lnl_socm_reg_map的定义或说明,可能会导致编译错误或未定义行为。
  • intel_vsec_walk_header函数中,ret的判断逻辑从if (ret)改为if (!ret),这可能会改变原有逻辑,需要确认这是否是预期的行为。

是否建议立即修改:

@matrix-wsk matrix-wsk merged commit 2172e42 into deepin-community:linux-6.6.y Jun 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants