Skip to content

Commit

Permalink
platform/x86/intel/pmc/arl: Put GNA device in D3
Browse files Browse the repository at this point in the history
mainline:ac2d1fd9688fcdfba5acc815fb2b13fec83e5dad
severity: Moderate

upstream commit ac2d1fd ("platform/x86/intel/pmc/arl: Put GNA device in D3")

As is the case on Meteor Lake, the Gaussian & Neural Accelerator (GNA)
device is powered by BIOS to D0 by default. If no driver is loaded, this
will cause the Package C state to be limited to PC2, leading to
significant power consumption and decrease in batter life.  Put the GNA
device in D3 by default if no driver is loaded for it.

Fixes: 83f168a ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver")

Intel-SIG: commit ac2d1fd ("platform/x86/intel/pmc/arl: Put GNA device in D3")

Signed-off-by: "David E. Box" <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
Reviewed-by: Kuppuswamy Sathyanarayanan <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Ilpo Järvinen <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
  • Loading branch information
debox1 authored and matrix-wsk committed Jun 14, 2024
1 parent 63747ff commit 2172e42
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/platform/x86/intel/pmc/arl.c
Original file line number Diff line number Diff line change
Expand Up @@ -673,13 +673,15 @@ static struct pmc_info arl_pmc_info_list[] = {
};

#define ARL_NPU_PCI_DEV 0xad1d
#define ARL_GNA_PCI_DEV 0xae4c
/*
* Set power state of select devices that do not have drivers to D3
* so that they do not block Package C entry.
*/
static void arl_d3_fixup(void)
{
pmc_core_set_device_d3(ARL_NPU_PCI_DEV);
pmc_core_set_device_d3(ARL_GNA_PCI_DEV);
}

static int arl_resume(struct pmc_dev *pmcdev)
Expand Down

0 comments on commit 2172e42

Please sign in to comment.