Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) input: Add a new serio driver for Phytium PCI PS/2 controller #203

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 27, 2024

Picked and rebased from #200.

From original pull request:

This driver supports Phytium PCI PS/2 controller.

Builds tested

  • amd64
  • arm64
  • loong64

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liujianqiang-niu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This driver supports Phytium PCI PS/2 controller.

Signed-off-by: Cheng Quan <[email protected]>
Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Chen Zhenhua <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Hu Yeqing <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/phytium-ps2 branch from 32ed0ed to 82a7786 Compare May 29, 2024 00:40
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_ps2_irq函数中,scancode变量被声明但未使用,应该移除或使用。
  • phytium_ps2_write函数中的val变量应该使用u8类型,因为只有一个8位的数据被写入设备。
  • phytium_ps2_openphytium_ps2_close函数中,ps2if变量的作用域应该是全局的,以避免在每次调用这些函数时都创建一个新的实例。
  • phytium_pci_ps2_probe函数中的ps2ifserio的内存分配应该使用devm_kzalloc,而不是kzalloc,以确保正确的内存分配策略。
  • phytium_pci_ps2_probephytium_pci_ps2_remove函数中,pdevps2if的引用计数没有增加,可能会导致在多线程环境中出现竞态条件。
  • STAT_RX_COUNTER宏函数在phytium_ps2_data结构体中没有定义,应该在代码中找到并补全。
  • phytium_pci_ps2_driver模块中缺少对phytium_pci_ps2_probephytium_pci_ps2_remove函数的文档说明。
  • phytium_pci_ps2_ids数组中的{ PCI_VDEVICE(PHYTIUM, 0xdc34) }定义了一个无效的设备ID,应该检查PHYTIUM的设备ID格式是否正确。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants