[Bugfix | Issue #2565] Network Switching and context to store update
#2595
Conversation
…or state management
…and remove unused chain switching logic
Da-Colon
changed the title
[Bugfix | Issue #2565] Network Switching and Context to Store update[Bugfix | Issue #2565] Network Switching and context to store update
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| // Create the Zustand store | ||
| export const useNetworkConfigStore = create<NetworkConfigStore>(set => ({ | ||
| ...sepoliaConfig, |
There was a problem hiding this comment.
defaults to sepolia...though probably should set this up pending on env? the only place this would be noticeable would be the network switcher...
Speaking of....we can probably get rid of that.....
and if we get rid of that we should probably add something somewhere to indicate what network you are on more explictly
|
I didn't update the network switcher to work with this setup. The app no longer cares what network the wallet is 'connected' to |
…work configuration handling
|
Discussed further with @nicolaus-sherrill the current plan is:
|
|
fantastic, thank you sir |
…issue/2565-network-config-updates
…proving icon visibility
…ended `[Issue #2565]` network config extended
There was a problem hiding this comment.
Have an issue loading a DAO name on Base, in the search menu.
Here's how I got to this situation:
- fresh instance of https://deploy-preview-2595.app.dev.decentdao.org/
- searched for "decentdao.eth" -> it popped up and the name loaded -> clicked it to go to the DAO. Saved it as a "Favorite".
- went back to home page
- pasted in
0x374D5a17D2433415C48C735A493F0523DaB99041to the search bar, which is the Base Myosin DAO address - screenshot 👇
|
Thanks on it. |
|
weird locally its working fine and can't reproduce. @adamgall, but I can reproduce on the deploy preview
hmmm preview is on the correct commit hmm I can't switch directly into searching for decentdao.eth as well
Finds both locally. |
We only really need to search for ENS names on mainnet
…S address resolution
…for single address resolution
…tion and update resolved address handling
…d update related logic
Refactor `useResolveAddressMultichain` to `useResolveENSName`
There was a problem hiding this comment.
Approving, but something's off with Base Myosin DAO. Navigating directly to https://deploy-preview-2595.app.dev.decentdao.org/home?dao=base:0x374D5a17D2433415C48C735A493F0523DaB99041 results in a white screen of death. Similar weird behaviour on dev and prod actually. However clicking into the DAO from saved list (after searching if on fresh cache) works fine.
|
I'm not getting any issues with this direct link... @DarksightKellar can you take a video of what you're experiencing |
|
@DarksightKellar Thanks, I can reproduce. On it |
Weird lol. Curious what's going on there |
|
@DarksightKellar I figured it out. Soon I saw the white screen I suspected something was up with around the wallet and it checking the connection. if it tries to switch chain prior to being ready, I believe it catches it self in a loop. I think the first attempt (first commit I just did) adding Anyway, fixed |
Da-Colon
merged commit fec54ef
into
issue/noIssue-state-loading-cleanup
|
Works! @Da-Colon In other news, would you know anything about this intermittent toast? Also only on myosin: 
|
|
yeah preexisting. I had made some updates, but I guess there is still something trying to load in state and not getting reset. I'll take a look |
Closes #2565
Updates the Network Provider to zustand store
Now switching networks don't cause a massive tree re-render
Fixes App Crash when navigating to a DAO on a different network via links, refresh or external link
We will need to test with other wallets, but now that 'being connected to a network' is decoupled from the choice in the wallet we don't need to use
switchchainanymoreScreenshots