Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Network Autoswitch not working properly #2565

Closed
Da-Colon opened this issue Nov 22, 2024 · 2 comments · Fixed by #2595
Closed

Bug Network Autoswitch not working properly #2565

Da-Colon opened this issue Nov 22, 2024 · 2 comments · Fixed by #2595
Assignees

Comments

@Da-Colon
Copy link
Contributor

Da-Colon commented Nov 22, 2024

Problem

Any attempt to use useSwitchChain results in nothing happening. This includes Favorites list and pasting a link in the URL if wallet is connected to a different wallet.

@Da-Colon Da-Colon added this to Decent Nov 22, 2024
@Da-Colon Da-Colon converted this from a draft issue Nov 22, 2024
@Da-Colon Da-Colon self-assigned this Nov 22, 2024
@Da-Colon
Copy link
Contributor Author

Da-Colon commented Nov 22, 2024

How it started

I was able to make good progress at first, Deleted the extra useSwitchChain on the navigate clicks and only relying on the useAutomaticNetworkSwitcher. I had it working accept for pasted URLs. and a error toast with RoleStores.....

Then I restarted, and chrome and metamask updated

Now

Now nothing works. which with my changes or without them. Metamask has updated to allow for modifying network switching permission allowing for apps to execute on any network without the popup....great...but now it doesn't work at all.....

This has bonked our current NetworkProvider and how we handle networks.

Effected Features

  • Wallet Menu | Network Switcher
  • Safe List Header | DAO of different network
  • Safe List Dashboard | DAO of different network
  • Automatic Network switching on URL link

Next Steps

I am thinking the next steps starts with a discussion and then a refactor of our NetworkProvider and how we handle network in our app. @decentdao/engineering

@Da-Colon Da-Colon assigned Da-Colon and unassigned Da-Colon Nov 22, 2024
@Da-Colon Da-Colon moved this from Ready to In review in Decent Dec 5, 2024
Da-Colon added a commit that referenced this issue Dec 16, 2024
Da-Colon added a commit that referenced this issue Dec 16, 2024
Da-Colon added a commit that referenced this issue Dec 17, 2024
…ates

`[Bugfix | Issue #2565]` Network Switching and context to store update
@DarksightKellar
Copy link
Contributor

Fixed in #2595

@github-project-automation github-project-automation bot moved this from In review to Done in Decent Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants