Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linear erc20 voting #1668

Merged
merged 6 commits into from
May 23, 2024
Merged

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 7, 2024

Please review and merge #1666 first.

@adamgall adamgall self-assigned this May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit ae94995
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/664a647bdaa002000881f06c
😎 Deploy Preview https://deploy-preview-1668.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the remove-fractalModule-typechain-from-fractalModuleData branch from 5c134de to 546a925 Compare May 7, 2024 17:59
@adamgall adamgall force-pushed the remove-linearErc20Voting branch from 759e980 to 5ce6725 Compare May 7, 2024 18:01
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments. Approved

@adamgall adamgall force-pushed the remove-fractalModule-typechain-from-fractalModuleData branch from 546a925 to 90fd4c6 Compare May 7, 2024 23:28
@adamgall adamgall force-pushed the remove-linearErc20Voting branch from 5ce6725 to 97c6677 Compare May 7, 2024 23:29
@Da-Colon
Copy link
Contributor

Da-Colon commented May 8, 2024

image

needs to make up its mind.

@adamgall
Copy link
Member Author

adamgall commented May 8, 2024

Whoops! not sure how that happened. Fixing now.

@adamgall adamgall force-pushed the remove-fractalModule-typechain-from-fractalModuleData branch from 90fd4c6 to 66d4a4f Compare May 8, 2024 20:11
@adamgall adamgall force-pushed the remove-linearErc20Voting branch from e9b9a7f to e8a48a7 Compare May 8, 2024 20:12
@adamgall adamgall force-pushed the remove-fractalModule-typechain-from-fractalModuleData branch from 66d4a4f to 4b802f1 Compare May 14, 2024 13:51
@adamgall adamgall force-pushed the remove-linearErc20Voting branch from e8a48a7 to 5dafa68 Compare May 14, 2024 13:52
@adamgall adamgall force-pushed the remove-fractalModule-typechain-from-fractalModuleData branch from 4b802f1 to b1e1722 Compare May 15, 2024 15:27
@adamgall adamgall force-pushed the remove-linearErc20Voting branch from 5dafa68 to 7757f01 Compare May 15, 2024 15:27
@adamgall adamgall force-pushed the remove-fractalModule-typechain-from-fractalModuleData branch from b1e1722 to b5086a1 Compare May 15, 2024 16:41
@adamgall adamgall force-pushed the remove-linearErc20Voting branch from 7757f01 to 6f80110 Compare May 15, 2024 16:41
@mudrila mudrila deleted the branch root/remove-typechain May 17, 2024 15:43
@mudrila mudrila closed this May 17, 2024
Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to parse event logs

@mudrila
Copy link
Contributor

mudrila commented May 17, 2024

@adamgall Apologies, I merged and deleted the branch that was targeted in this PR and seems like now we can't re-open this PR - do you mind opening up another one targeting root remove typechain branch and reflecting on comments that I left in the review?

@adamgall adamgall reopened this May 19, 2024
@adamgall adamgall changed the base branch from remove-fractalModule-typechain-from-fractalModuleData to root/remove-typechain May 19, 2024 20:36
@adamgall adamgall marked this pull request as ready for review May 19, 2024 20:36
@adamgall
Copy link
Member Author

@adamgall Apologies, I merged and deleted the branch that was targeted in this PR and seems like now we can't re-open this PR - do you mind opening up another one targeting root remove typechain branch and reflecting on comments that I left in the review?

@mudrila i was able to open this one back up after some branch manipulation 👍

@adamgall adamgall force-pushed the remove-linearErc20Voting branch from e13ad9f to ae94995 Compare May 19, 2024 20:43
@adamgall adamgall merged commit 335521f into root/remove-typechain May 23, 2024
7 checks passed
@adamgall adamgall deleted the remove-linearErc20Voting branch May 23, 2024 11:54
@adamgall adamgall restored the remove-linearErc20Voting branch May 23, 2024 12:00
@adamgall adamgall deleted the remove-linearErc20Voting branch May 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants