Remove linear erc721 voting #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Da-Colon
reviewed
May 7, 2024
| tokenId, | ||
| ); | ||
| const tokenVoted = await votingContract.read.hasVoted([ | ||
| Number(_proposalId), |
There was a problem hiding this comment.
Can proposal Id ever be anything but a number? possibly so? just wanted to ask anyway
There was a problem hiding this comment.
Good call out. Found some bugs here. Fixing now.
There was a problem hiding this comment.
Well, fixed the bugs (5fade89).
I also moved where this cast was happening, but TL;DR is that by the time this code here is executing, _proposalId, although a string, is a number. I certainly don't love this. The deeper issue is that we're sharing so many types/interfaces between erc20/erc721/multisig/snapshot proposals, when we really shouldn't be.
Da-Colon
approved these changes
May 7, 2024
adamgall
force-pushed
the
remove-linearErc20Voting
branch
from
5ce6725 to
97c6677
Compare
adamgall
force-pushed
the
remove-linearErc721Voting
branch
2 times, most recently
from
4e763e6 to
0592a19
Compare
adamgall
force-pushed
the
remove-linearErc20Voting
branch
from
e9b9a7f to
e8a48a7
Compare
adamgall
force-pushed
the
remove-linearErc721Voting
branch
from
0592a19 to
128214a
Compare
adamgall
force-pushed
the
remove-linearErc20Voting
branch
from
e8a48a7 to
5dafa68
Compare
adamgall
force-pushed
the
remove-linearErc721Voting
branch
from
128214a to
afb326c
Compare
adamgall
force-pushed
the
remove-linearErc20Voting
branch
from
5dafa68 to
7757f01
Compare
adamgall
force-pushed
the
remove-linearErc721Voting
branch
from
afb326c to
143efd2
Compare
adamgall
force-pushed
the
remove-linearErc20Voting
branch
from
7757f01 to
6f80110
Compare
adamgall
force-pushed
the
remove-linearErc721Voting
branch
from
143efd2 to
060a635
Compare
adamgall
force-pushed
the
remove-linearErc20Voting
branch
from
e13ad9f to
ae94995
Compare
adamgall
force-pushed
the
remove-linearErc721Voting
branch
from
060a635 to
bef29c0
Compare
mudrila
approved these changes
May 23, 2024
adamgall
changed the base branch from
remove-linearErc20Voting
to
root/remove-typechain
…UserSubmitProposal
…721LinearStrategy
…oriusContracts, useSafeContracts
adamgall
force-pushed
the
remove-linearErc721Voting
branch
from
bef29c0 to
bfcaeac
Compare
…the function is being called, proposalId must be a numberish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #1668 first.