Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gnosis safe l2 typechain #1662

Merged
merged 5 commits into from
May 8, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1661 first.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 0c36e40
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663bd946bd865300085bdb9f
😎 Deploy Preview https://deploy-preview-1662.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall self-assigned this May 7, 2024
@adamgall adamgall force-pushed the remove-safeSingletonContract-from-useSafeContracts branch from 2670d6e to 91c0f27 Compare May 7, 2024 17:58
@adamgall adamgall force-pushed the remove-GnosisSafeL2-Typechain branch from 801934a to 3722e01 Compare May 7, 2024 17:58
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamgall adamgall force-pushed the remove-safeSingletonContract-from-useSafeContracts branch from 91c0f27 to f4a19d9 Compare May 7, 2024 23:28
@adamgall adamgall force-pushed the remove-GnosisSafeL2-Typechain branch from 3722e01 to 9a4a5df Compare May 7, 2024 23:28
const safeContract = GnosisSafeL2__factory.connect(safeAddress, this.signerOrProvider);
this.safeContract = safeContract;
public setSafeContract(safeAddress: Address) {
// const safeContract = GnosisSafeL2__factory.connect(safeAddress, this.signerOrProvider);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing this comment is/will be removed further up the PR ladder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, deleted.

@adamgall adamgall force-pushed the remove-safeSingletonContract-from-useSafeContracts branch from f4a19d9 to 7c953d3 Compare May 8, 2024 19:51
Base automatically changed from remove-safeSingletonContract-from-useSafeContracts to root/remove-typechain May 8, 2024 19:54
@adamgall adamgall force-pushed the remove-GnosisSafeL2-Typechain branch from 9a4a5df to dc6ccf8 Compare May 8, 2024 19:55
@adamgall adamgall marked this pull request as ready for review May 8, 2024 19:55
@adamgall adamgall merged commit c15bb0d into root/remove-typechain May 8, 2024
7 checks passed
@adamgall adamgall deleted the remove-GnosisSafeL2-Typechain branch May 8, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants