Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Multisend Typechain #1663

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1662 first.

Remove all instances of MultiSend objects from FractalContracts, BaseContracs, useSafeContracts, etc

Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 386d882
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663bdb21a4b8660008355b2e
😎 Deploy Preview https://deploy-preview-1663.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall self-assigned this May 7, 2024
@adamgall adamgall force-pushed the remove-GnosisSafeL2-Typechain branch from 801934a to 3722e01 Compare May 7, 2024 17:58
@adamgall adamgall force-pushed the remove-multisend branch from 194b834 to c2a27fa Compare May 7, 2024 17:58
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d.d.d.deleted.

@adamgall adamgall force-pushed the remove-GnosisSafeL2-Typechain branch from 3722e01 to 9a4a5df Compare May 7, 2024 23:28
@adamgall adamgall force-pushed the remove-multisend branch from c2a27fa to 281f979 Compare May 7, 2024 23:28
export const encodeMultiSend = (txs: MetaTransaction[]): string => {
return '0x' + txs.map(tx => encodeMetaTransaction(tx)).join('');
export const encodeMultiSend = (txs: MetaTransaction[]): Hex => {
return `0x${txs.map(tx => encodeMetaTransaction(tx)).join('')}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝🏾

@adamgall adamgall force-pushed the remove-GnosisSafeL2-Typechain branch from 9a4a5df to dc6ccf8 Compare May 8, 2024 19:55
Base automatically changed from remove-GnosisSafeL2-Typechain to root/remove-typechain May 8, 2024 20:01
@adamgall adamgall force-pushed the remove-multisend branch from 281f979 to 386d882 Compare May 8, 2024 20:05
@adamgall adamgall marked this pull request as ready for review May 8, 2024 20:05
@adamgall adamgall merged commit 32d6928 into root/remove-typechain May 8, 2024
7 checks passed
@adamgall adamgall deleted the remove-multisend branch May 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants