Base support #1534
Base support #1534
Conversation
adamgall
requested review from
DarksightKellar,
mudrila,
tomstuart123 and
Da-Colon
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| nativeTokenSymbol: mainnet.nativeCurrency.symbol, | ||
| nativeTokenIcon: '/images/coin-icon-eth.svg', | ||
| wagmiChain: mainnet, | ||
| subgraphChainName: 'mainnet', | ||
| subgraph: { | ||
| space: 71032, |
There was a problem hiding this comment.
Does this mean we have this subgraph deployed under new space?
…n src/providers/NetworkConfig/networks/*
There was a problem hiding this comment.
Few minor suggestions about removing duplicated config. chain and wagmiChain seem to be the same, also name can be derived from chain, as well as nativeTokenSymbol - don't see a reason to keep that configurable unless there's a clear reason why we'll be passing different values there
| @@ -27,17 +27,23 @@ const CHAIN_ID = 1; | |||
| const SAFE_VERSION = '1.3.0'; | |||
|
|
|||
| export const mainnetConfig: NetworkConfig = { | |||
| order: 0, | |||
| chain: mainnet, | |||
| rpcEndpoint: `https://eth-mainnet.g.alchemy.com/v2/${import.meta.env.VITE_APP_ALCHEMY_MAINNET_API_KEY}`, | |||
| @@ -27,17 +27,23 @@ const CHAIN_ID = 137; | |||
| const SAFE_VERSION = '1.3.0'; | |||
|
|
|||
| export const polygonConfig: NetworkConfig = { | |||
| order: 20, | |||
There was a problem hiding this comment.
Oh no real reason, just so that we "have room" when adding new networks (won't need to re-order all of the other networks).
For example, say we add Optimism next, and want it between Base and Polygon.
Currently Base is 10, Polygon is 20.
We could set the order property in the new Optimism config to 15 and it'll show up where we want it to, without needing to adjust any of the other networks' configs.
Closes #1532
Adds Base support
Some cleanup along the way:
src/providers/NetworkConfig/networks/*The changes in this PR definitely succumbed to scope creep as I cleaned up the NetworkConfig type, but the updates were all super straightforward and I'm not running into any problems as I test locally