2024-04-17 release #1574
Merged
2024-04-17 release #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- (note) fractal-contracts deployment version not updated
called `nonceWithPending`, which will be the next nonce to use which takes into account all "pending" transactions on the safe
Operating under the assumption that any time in the app we're utilizing the `nonce`, it's because we want to create a proposal. Under this assumption, we'll always want to take "pending transactions" into account. Also, this new code handles the cases in which: - There are no pending transactions - There are multiple pending transactions with the same nonce
…t _not_ using the Safe data from global state
…more generic to be compatible with creating regular proposal
Release 2024-04-08 Part 2: Finish the Git Flow
Support base sepolia
…es-builder Refactor CreateProposalTemplateForm into generic ProposalBuilder
This validation attempts to normalize the input, and passes if it does not throw. See: https://docs.ens.domains/resolution/names#normalize
Bug/multisig nonce selection
…patibility with outside world's snapshotURL
Snapshot space input bug
Fix dao settings' snapshot ens placeholder
✅ Deploy Preview for fractal-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following PRs: