Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX + CLEANUP] From dependency update #1355

Closed
wants to merge 2 commits into from

Conversation

Da-Colon
Copy link
Contributor

Description

Branched off #1354 for a a bug fix that has been bothering me and removing a unneeded component.

Etherscan Link: There was a nested div as a child of a <a>. The error wasn't effecting anything just showing up in console.

ClientOnly Component: We no longer need this component based on the updates in the previous PR. I've remove this component for all of the AppRouter pages.

Notes

Issue / Notion doc (if applicable)

Testing

Screenshots (if applicable)

@Da-Colon Da-Colon self-assigned this Feb 16, 2024
@Da-Colon Da-Colon added the bug Something isn't working label Feb 16, 2024
@Da-Colon Da-Colon changed the title Dc/upgrade fixes [BUGFIX + CLEANUP] Various Feb 16, 2024
@Da-Colon Da-Colon changed the title [BUGFIX + CLEANUP] Various [BUGFIX + CLEANUP] From dependency update Feb 16, 2024
Copy link

@xhad xhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a localStorage error, which appears to be NextJs trying to store something to localstorage while server rendering some code....

ReferenceError: localStorage is not defined
    at r.setItem (/Users/loreum/Code/decent/fractal/fractal-interface/.next/server/chunks/235.js:1:27462)
    at new f (/Users/loreum/Code/decent/fractal/fractal-interface/.next/server/chunks/235.js:1:938)
    at Object.getProvider (/Users/loreum/Code/decent/fractal/fractal-interface/.next/server/chunks/479.js:7270:29969)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async a (/Users/loreum/Code/decent/fractal/fractal-interface/.next/server/chunks/479.js:7409:39537)
    ```
    
   Steps to Reproduce:
   
   1. `npm run build`
   2. `npm start`
   
   When I got to the app, the console displays this error

@Da-Colon Da-Colon closed this Feb 19, 2024
@Da-Colon Da-Colon deleted the dc/upgrade-fixes branch February 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants