[REFACTOR AND UPGRADE] Rainbowkit -> Web3Modal #1354
Conversation
- remove @rainbow-me/rainbowkit - added @tanstack/react-query - added @web3modal/wagmi - updated next @13.3.0 -> @14.0.3 - Updates node version in nvmrc and engine to compatible version
✅ Deploy Preview for fractal-framework-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| </WagmiConfig> | ||
| </FractalErrorBoundary> | ||
| </ChakraProvider> | ||
| <Providers>{children}</Providers> |
There was a problem hiding this comment.
This was prompted by seeing why the Header was seemingly mounting differently. While this didn't solve the issue I was looking for. pulling the imports out of the app directly seems to speed up a little how the app fast the app is ready
| @@ -15,6 +15,5 @@ module.exports = { | |||
| }, | |||
| experimental: { | |||
| esmExternals: false, | |||
| appDir: true, | |||
There was a problem hiding this comment.
No longer required as of version 13.4
| "@safe-global/safe-deployments": "^1.23.0", | ||
| "@safe-global/safe-ethers-lib": "^1.9.2", | ||
| "@safe-global/safe-service-client": "^1.5.2", | ||
| "@sentry/react": "^7.42.0", | ||
| "@sentry/react": "^7.101.0", |
There was a problem hiding this comment.
Sentry needed to be updated because of the node version update
| const wagmiChainId = useChainId(); | ||
| const chainId = wagmiChainId ? wagmiChainId : disconnectedChain.id; |
There was a problem hiding this comment.
Just in case this gets called out, I didn't want to mess with the current functionality and didn't want to miss with how the app interacts with the provider in this PR
There was a problem hiding this comment.
Didn't want to spend the time upgrading. If we need to create a new test wallet using Web3Modal tooling
|
|
||
| function Header() { | ||
| return ( | ||
| <ClientOnly> |
There was a problem hiding this comment.
See more about this change in #1355
| @@ -32,7 +33,6 @@ export default function useDAOName({ | |||
| const { data: ensName } = useEnsName({ | |||
| address: address as Address, | |||
| chainId: networkId, | |||
| cacheTime: 1000 * 60 * 30, // 30 min | |||
There was a problem hiding this comment.
It seems that the cacheTime property was removed from all the wagmi hooks
adamgall
changed the title
adamgall
changed the title
adamgall
force-pushed
the
dc/upgrade-rainbowkit
branch
from
b5d2f6c to
46dd276
Compare
adamgall
added
maintenance
Pull Request: Wallet Provider Upgrade and Dependency Updates
Description
This pull request introduces a significant update and upgrade to our wallet provider interface, aiming to enhance the WalletConnect functionality for users. The integration of the latest dependencies required extensive updates across multiple files due to the breaking nature of these changes. Notably, this overhaul necessitated an update to the Node.js version, alongside modifications to the
.nvmrcfile and theenginesfield inpackage.json.Efforts were made to retain the existing settings and behavior of
rainbowkitto ensure that users experience no perceptible difference in the interface's feel.I will highlight additional specifics in a separate code review within this pull request.
Notes
Testing
Comprehensive testing will need to be done:
For best experience I'd test using #1355
Screenshots