Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENTERPRISE-724: Allie / updating ip restriction docs #3963

Merged
merged 10 commits into from
Sep 11, 2023
Merged

ENTERPRISE-724: Allie / updating ip restriction docs #3963

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb71772
updating ip restriction docs
nm0s Aug 21, 2023
b7572a1
updating docs for integrations
nm0s Aug 31, 2023
0391756
Merge branch 'current' into allie/updating-docs-to-reflect-service-to…
nm0s Aug 31, 2023
6ada03b
Merge branch 'current' into allie/updating-docs-to-reflect-service-to…
mirnawong1 Sep 4, 2023
5e0429c
Merge branch 'current' into allie/updating-docs-to-reflect-service-to…
nm0s Sep 7, 2023
5f79405
adding whitespace
nm0s Sep 7, 2023
19ccd8c
minor changes
nm0s Sep 11, 2023
a10cb3a
Apply suggestions from code review
matthewshaver Sep 11, 2023
9ed5f59
Update website/docs/docs/cloud/git/connect-gitlab.md
matthewshaver Sep 11, 2023
0c98632
Merge branch 'current' into allie/updating-docs-to-reflect-service-to…
matthewshaver Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions website/docs/docs/cloud/git/connect-azure-devops.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ To connect Azure DevOps in dbt Cloud:
2. dbt Cloud developers need to [personally authenticate with Azure DevOps](/docs/cloud/git/authenticate-azure) from dbt Cloud.


If you're a Business Critical customer using IP restrictions ensure you've added the appropriate Azure DevOps CIDRs to your IP restriction rules, or else the Azure DevOps connection will fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using IP restrictions ensure

nit: a , before ensure.
Can you also link IP restrictions back to website/docs/docs/cloud/secure/ip-restrictions.md docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar below.

2 changes: 2 additions & 0 deletions website/docs/docs/cloud/git/connect-gitlab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ The application form in GitLab should look as follows when completed:

Click **Save application** in GitLab, and GitLab will then generate an **Application ID** and **Secret**. These values will be available even if you close the app screen, so this is not the only chance you have to save them.

If you're a Business Critical customer using IP restrictions ensure you've added the appropriate Gitlab CIDRs to your IP restriction rules, or else the Gitlab connection will fail.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saimaddali I've added these lines to the bottom of the gitlab and ADO integration sections - would you rather these be in a more visible place?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add it to the ip restriction docs (website/docs/docs/cloud/secure/ip-restrictions.md)


### Adding the GitLab OAuth application to dbt Cloud
After you've created your GitLab application, you need to provide dbt Cloud information about the app. In dbt Cloud, account admins should navigate to **Account Settings**, click on the **Integrations** tab, and expand the GitLab section.

Expand Down
2 changes: 1 addition & 1 deletion website/docs/docs/cloud/secure/ip-restrictions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ To configure IP restrictions, go to **Account Settings** → **IP Restrictions**
- Deny IPs flagged by the Security team
- Allow only VPN traffic but make an exception for contractors’ IP addresses

IP restrictions will block all user requests done via the API (via personal user token) and the UI. Service tokens are exempt from IP restrictions and can still make requests to dbt Cloud API.
IP restrictions will block all service tokens, user requests done via the API (via personal user token), and the UI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IP restrictions will block all service tokens requests, user requests done via the API (via personal user token), and the UI, if they are coming from blocked IP addresses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for you can add a note about integrations using serviceTokens.
"For any versionControl system integrations inbound into dbt Cloud, ensure their IP addresses are added to the allowed list. Examples: Gitlab, ADO and Github"


### Allowing IPs

Expand Down
Loading