ENTERPRISE-724: Allie / updating ip restriction docs #3963
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
| @@ -71,6 +71,8 @@ The application form in GitLab should look as follows when completed: | |||
|
|
|||
| Click **Save application** in GitLab, and GitLab will then generate an **Application ID** and **Secret**. These values will be available even if you close the app screen, so this is not the only chance you have to save them. | |||
|
|
|||
| If you're a Business Critical customer using IP restrictions ensure you've added the appropriate Gitlab CIDRs to your IP restriction rules, or else the Gitlab connection will fail. | |||
There was a problem hiding this comment.
@saimaddali I've added these lines to the bottom of the gitlab and ADO integration sections - would you rather these be in a more visible place?
There was a problem hiding this comment.
Let's also add it to the ip restriction docs (website/docs/docs/cloud/secure/ip-restrictions.md)
| @@ -23,3 +23,4 @@ To connect Azure DevOps in dbt Cloud: | |||
| 2. dbt Cloud developers need to [personally authenticate with Azure DevOps](/docs/cloud/git/authenticate-azure) from dbt Cloud. | |||
|
|
|||
|
|
|||
| If you're a Business Critical customer using IP restrictions ensure you've added the appropriate Azure DevOps CIDRs to your IP restriction rules, or else the Azure DevOps connection will fail. | |||
There was a problem hiding this comment.
using IP restrictions ensure
nit: a , before ensure.
Can you also link IP restrictions back to website/docs/docs/cloud/secure/ip-restrictions.md docs
| @@ -71,6 +71,8 @@ The application form in GitLab should look as follows when completed: | |||
|
|
|||
| Click **Save application** in GitLab, and GitLab will then generate an **Application ID** and **Secret**. These values will be available even if you close the app screen, so this is not the only chance you have to save them. | |||
|
|
|||
| If you're a Business Critical customer using IP restrictions ensure you've added the appropriate Gitlab CIDRs to your IP restriction rules, or else the Gitlab connection will fail. | |||
There was a problem hiding this comment.
Let's also add it to the ip restriction docs (website/docs/docs/cloud/secure/ip-restrictions.md)
| @@ -19,7 +19,7 @@ To configure IP restrictions, go to **Account Settings** → **IP Restrictions** | |||
| - Deny IPs flagged by the Security team | |||
| - Allow only VPN traffic but make an exception for contractors’ IP addresses | |||
|
|
|||
| IP restrictions will block all user requests done via the API (via personal user token) and the UI. Service tokens are exempt from IP restrictions and can still make requests to dbt Cloud API. | |||
| IP restrictions will block all service tokens, user requests done via the API (via personal user token), and the UI. | |||
There was a problem hiding this comment.
IP restrictions will block all service tokens requests, user requests done via the API (via personal user token), and the UI, if they are coming from blocked IP addresses.
There was a problem hiding this comment.
This is for you can add a note about integrations using serviceTokens.
"For any versionControl system integrations inbound into dbt Cloud, ensure their IP addresses are added to the allowed list. Examples: Gitlab, ADO and Github"
matthewshaver
deleted the
allie/updating-docs-to-reflect-service-token-changes
branch
What are you changing in this pull request and why?
Updating docs to reflect that service tokens will now be blocked by ip restrictions. And BC customers with Gitlab or ADO integrations must add their respective integration ips to their ip rules
Checklist
Adding new pages (delete if not applicable):
website/sidebars.jsRemoving or renaming existing pages (delete if not applicable):
website/sidebars.jswebsite/static/_redirects