Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove non-current iceberg columns from catalog #731

Merged

Conversation

svdimchenko
Copy link
Contributor

@svdimchenko svdimchenko commented Sep 30, 2024

Description

Remove non-current iceberg columns from catalog

Models used to test - Optional

{{
    config(
        materialized="table",
        table_type="iceberg",
        post_hook="alter table model drop column to_drop"
    )
}}
select 1 as id, 'to_drop' as to_drop

Previously, dbt docs generate command generated catalog.json artifact which included to_drop column as well, however it did not exist in current table version.
Current PR fixes this behaviour and stores in catalog.json file only actual columns.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@svdimchenko svdimchenko marked this pull request as ready for review September 30, 2024 12:29
@svdimchenko svdimchenko requested a review from a team as a code owner September 30, 2024 12:29
@nicor88
Copy link
Contributor

nicor88 commented Sep 30, 2024

Should fix #726

@svdimchenko svdimchenko changed the title Fix: Remove non-current iceberg columns from catalog fix: Remove non-current iceberg columns from catalog Sep 30, 2024
@nicor88
Copy link
Contributor

nicor88 commented Sep 30, 2024

@colin-rogers-dbt please have a look.

@colin-rogers-dbt colin-rogers-dbt merged commit fea86ff into dbt-labs:main Sep 30, 2024
8 checks passed
@svdimchenko svdimchenko deleted the fix/catalog-json-iceberg-columns branch October 1, 2024 10:36
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 2, 2024
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants