Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] dbt docs shown not actual iceberg columns #726

Closed
2 tasks done
nicor88 opened this issue Sep 23, 2024 · 1 comment
Closed
2 tasks done

[Bug] dbt docs shown not actual iceberg columns #726

nicor88 opened this issue Sep 23, 2024 · 1 comment
Labels
bug Something isn't working iceberg This issue concerns Iceberg integration

Comments

@nicor88
Copy link
Contributor

nicor88 commented Sep 23, 2024

Is this a new bug in dbt-athena?

  • I believe this is a new bug in dbt-athena
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When generating catalog.json via dbt docs, if an Iceberg table has a column that's being dropped, the column is still shown in the catalog.json.
Iceberg tables keep track of not actual column via the property iceberg.field.current, that should be used to exclude not current columns.

Expected Behavior

Dropped columns for iceberg tables are not shown.

Steps To Reproduce

  1. Create an iceberg table
  2. Manually drop a column
  3. Generate dbt docs

Environment

- OS:
- Python:
- dbt:
- dbt-athena-community: 1.8.2

Additional Context

https://github.com/dbt-labs/dbt-athena/pull/189/files

@nicor88 nicor88 added the bug Something isn't working label Sep 23, 2024
@amychen1776 amychen1776 added the iceberg This issue concerns Iceberg integration label Oct 2, 2024
@nicor88
Copy link
Contributor Author

nicor88 commented Oct 2, 2024

This issue was addressed by #731

@nicor88 nicor88 closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iceberg This issue concerns Iceberg integration
Projects
None yet
Development

No branches or pull requests

2 participants