Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form elements border color #3601

Merged
merged 6 commits into from
Dec 16, 2024
Merged

fix: form elements border color #3601

merged 6 commits into from
Dec 16, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 13, 2024 •
edited
Loading

Proposed changes

Currently the form elements border are failing WCAG Success Criteria 1.4.11, as the contrast ration doesn't meet the minimum of 3:1 to their underlaying background color.

DBUXDS-4044

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🐛bug Something isn't working 🏘components Changes inside components folder 👂accessibility Accessibility issues/improvements labels Dec 13, 2024
@mfranzke mfranzke self-assigned this Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-form-elements-border-color-alternative

@mfranzke mfranzke mentioned this pull request Dec 13, 2024
Closed
5 tasks
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Dec 13, 2024
@mfranzke mfranzke marked this pull request as ready for review December 13, 2024 20:52
@mfranzke mfranzke requested a review from leape December 13, 2024 20:52
@mfranzke mfranzke enabled auto-merge (squash) December 13, 2024 20:53
@mfranzke mfranzke removed their assignment Dec 13, 2024
@mfranzke mfranzke merged commit a83866d into main Dec 16, 2024
74 checks passed
@mfranzke mfranzke deleted the fix-form-elements-border-color-alternative branch December 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

@leape leape Awaiting requested review from leape

Assignees
No one assigned
Labels
👂accessibility Accessibility issues/improvements 🐛bug Something isn't working 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget