Skip to content

Commit

Permalink
fix: form elements border color (#3601)
Browse files Browse the repository at this point in the history
* fix: form elements border color

* test: updated screenshots

* test: updated screenshots

* test: updated screenshots

* Update _accessibility-review.json
  • Loading branch information
mfranzke authored Dec 16, 2024
1 parent 188b896 commit a83866d
Show file tree
Hide file tree
Showing 31 changed files with 12 additions and 2 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/components/src/components/textarea/textarea.scss
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
}

&::after {
@extend %component-border;
@extend %form-component-border;

@include get-scrolling-workaround();

Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/styles/_component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ $placeholder-disabled: 0.68;
colors.$db-adaptive-on-bg-basic-emphasis-60-default;
}

%form-component-border {
border: variables.$db-border-height-3xs solid
colors.$db-adaptive-on-bg-basic-emphasis-70-default;
}

%default-interactive-component {
@extend %default-adaptive-border;

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/styles/_form-components.scss
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ $input-valid-types: "color", "date", "datetime-local", "email", "file",
#{$selector} {
@extend %db-overwrite-font-size-md;
@extend %default-interactive-component;
@extend %component-border;
@extend %form-component-border;

background-color: colors.$db-adaptive-bg-basic-transparent-semi-default;
caret-color: colors.$db-adaptive-on-bg-basic-emphasis-100-default;
Expand Down
5 changes: 5 additions & 0 deletions showcases/shared/_accessibility-review.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,10 @@
"name": "card",
"status": "DONE",
"date": "2024-12-12"
},
{
"name": "textarea",
"status": "DONE",
"date": "2024-12-12"
}
]

0 comments on commit a83866d

Please sign in to comment.