Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: optimized selectors #2877

Merged
merged 3 commits into from
Jul 23, 2024
Merged

refactor: optimized selectors #2877

merged 3 commits into from
Jul 23, 2024

Conversation

mfranzke
Copy link
Member

Proposed changes

Optimized some CSS selectors especially in the context of SCSS.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke
refactor: optimized this selector
2ea81c9 
especially in this context of SCSS
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jul 17, 2024
@mfranzke mfranzke added this to the v0.3.0 milestone Jul 17, 2024
@mfranzke mfranzke self-assigned this Jul 17, 2024
@mfranzke mfranzke linked an issue Jul 17, 2024 that may be closed by this pull request
refactor(scss): improve selectors by grouping #2856
Closed
@github-actions github-actions bot added the 🏘components Changes inside components folder label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2856-refactorscss-improve-selectors-by-grouping

@mfranzke mfranzke marked this pull request as draft July 17, 2024 09:19
@mfranzke mfranzke removed their assignment Jul 17, 2024
@mfranzke mfranzke marked this pull request as ready for review July 17, 2024 09:23
@mfranzke mfranzke enabled auto-merge July 17, 2024 11:07
@mfranzke mfranzke merged commit 67e957e into main Jul 23, 2024
54 checks passed
@mfranzke mfranzke deleted the 2856-refactorscss-improve-selectors-by-grouping branch July 23, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder 🍄🆙improvement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

refactor(scss): improve selectors by grouping
2 participants
@mfranzke @nmerget