Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(scss): improve selectors by grouping #2856

Closed
mfranzke opened this issue Jul 11, 2024 · 0 comments · Fixed by #2877
Closed

refactor(scss): improve selectors by grouping #2856

mfranzke opened this issue Jul 11, 2024 · 0 comments · Fixed by #2877
Labels
🍄🆙improvement New feature or request 😍nice to have Nice to have things

Comments

@mfranzke
Copy link
Member

mfranzke commented Jul 11, 2024 •
edited
Loading

we could easily group declarations (by :is()) like e.g. the following, so that we generate smaller output:

mono/packages/components/src/components/tag/tag.scss

Lines 118 to 121 in da6aac7

&:not(:disabled):hover,
&,
&:not(:disabled):focus,
&:not(:disabled):active {

@mfranzke mfranzke added 🍄🆙improvement New feature or request 😍nice to have Nice to have things labels Jul 11, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 RC milestone Jul 11, 2024
@mfranzke mfranzke linked a pull request Jul 17, 2024 that will close this issue
refactor: optimized selectors #2877
Merged
5 tasks
@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍄🆙improvement New feature or request 😍nice to have Nice to have things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: optimized selectors db-ui/mono
1 participant
@mfranzke