This repository has been archived by the owner on Jun 26, 2022. It is now read-only.
Updated to use iframe for opened room / adding client ID to the IP address #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes the way room is opened. Instead of directly opening jisi room, it opens a wrapper which uses jitsi API to open the room as iframe (Thank you @katjaq for the idea #59), and by doing so, I've moved the people counter code to this wrapper so that it can keep up with which rooms are open/closed.
I've also updated on the server side to include "client ID". This makes each jitsi tabs unique so you can open 2 tabs and it will registered as 2 people.
This fixed the issue #58