Skip to content
This repository has been archived by the owner on Jun 26, 2022. It is now read-only.

posters-overrides.json did not overwrite video chat url #75

Closed
htwangtw opened this issue Jun 26, 2020 · 6 comments
Closed

posters-overrides.json did not overwrite video chat url #75

htwangtw opened this issue Jun 26, 2020 · 6 comments

Comments

@htwangtw
Copy link
Contributor

On the current website, the video chats are the default jitsi rooms.
I picked a few from posters-overrides.json and posters.json to check. The values in these two files are correct, but the website display is not right. I am not entirely sure if this is just a delay of updating the website. I have refreshed the page several times over 5 minutes and the behaviour remains the same.
PDFs are being overwritten correctly. I didn't investigate if other values not being correctly overwritten.

@yarikoptic
Copy link
Contributor

oh, thanks! I guess it was a side-effect of recent enhancement to track... yes
https://github.com/datalad-datasets/ohbm2020-posters/blob/gh-pages/assets/js/main.js#L229

mints urls instead of reusing ... I will look into fixing it now, and if I fail - will ask @soichih for help ;)

@yarikoptic
Copy link
Contributor

yes, I failed -- I realized that we store complete html reference in videochat field, so it needs to be parsed to extract URL and name of the room to be passed to openJit. Dear @soichih - please help!!!

@soichih
Copy link
Contributor

soichih commented Jun 26, 2020

Ah, I forgot about this too. I will update my recent PR.

@soichih
Copy link
Contributor

soichih commented Jun 26, 2020

Actually, I think I should wait for #43 to get merged before I touch this?

I am going to update those 6 "videochat" override entry to just contain the jitsi room name (except the one that uses zoom link - we need to implement something similar to what I did with #79 with that one. Or can we just ask that they use jitsi instead?

@htwangtw
Copy link
Contributor Author

Yeah I think this is really not an emergency since there are only six entries.
Thanks for picking this up!

@yarikoptic
Copy link
Contributor

I think this was fixed in the one of the last PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants