This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 16, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Jan 17, 2022
kabilar
reviewed
Feb 28, 2022
Co-authored-by: Kabilar Gunalan <[email protected]>
kabilar
reviewed
Mar 1, 2022
Co-authored-by: Kabilar Gunalan <[email protected]>
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
Co-authored-by: Kabilar Gunalan <[email protected]>
I've added the manifest file, but will hold off on renaming pending dev request #20. I've also changed |
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
reviewed
Mar 1, 2022
kabilar
suggested changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CBroz1. Great work. Few suggestions above. We are close to merging!
kabilar
reviewed
Mar 2, 2022
kabilar
reviewed
Mar 2, 2022
kabilar
reviewed
Mar 2, 2022
Co-authored-by: Kabilar Gunalan <[email protected]>
kabilar
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CBroz1!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
element-interface.utils
path functionsverbose
boolean to integration tests for simpler outputPending: