Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Update to permit multiple root dirs #33

Merged
merged 47 commits into from
Mar 2, 2022
Merged

Update to permit multiple root dirs #33

merged 47 commits into from
Mar 2, 2022

Conversation

CBroz1
Copy link
Contributor

@CBroz1 CBroz1 commented Nov 12, 2021

Changed:

  • Updated mosts tests with docstrings.
  • PEP8
    • line length to ≤ 88
    • removed unused dependencies
    • full words in variable/function names
  • Include element-interface.utils path functions
  • Rebased with main commit history
  • Added verbose boolean to integration tests for simpler output
  • Changed docker.test command for more complete coverage test output

Pending:

  • Successful docker integration tests

@CBroz1 CBroz1 marked this pull request as ready for review November 12, 2021 23:25
@kabilar kabilar assigned kabilar and unassigned yambottle and ttngu207 Dec 29, 2021
tests/test_populate.py Outdated Show resolved Hide resolved
tests/test_populate.py Outdated Show resolved Hide resolved
tests/test_populate.py Outdated Show resolved Hide resolved
tests/test_populate.py Outdated Show resolved Hide resolved
tests/test_populate.py Outdated Show resolved Hide resolved
@kabilar kabilar added this to the NIH U24 Year 2 milestone Jan 17, 2022
tests/test_ingest.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
tests/test_ingest.py Outdated Show resolved Hide resolved
docker-compose-test.yaml Outdated Show resolved Hide resolved
@CBroz1
Copy link
Contributor Author

CBroz1 commented Mar 1, 2022

  • I believe the djarchive-manifest.csv file will need to be within <bucket>/workflow-array-ephys-benchmark/0.1.0a4/.
  • The djarchive-manifest.csv file will need to be updated for the new subdirectories (workflow_ephys_data1, workflow_ephys_data2).
  • Let's rename the revision 0.1.0a4 to v2.

I've added the manifest file, but will hold off on renaming pending dev request #20.

I've also changed tests/__init__.py to reflect the hardcoded v2 versioning for this test dataset.

tests/__init__.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
tests/test_ingest.py Outdated Show resolved Hide resolved
tests/test_ingest.py Outdated Show resolved Hide resolved
tests/test_ingest.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBroz1. Great work. Few suggestions above. We are close to merging!

tests/test_ingest.py Outdated Show resolved Hide resolved
tests/test_ingest.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBroz1!

@kabilar kabilar merged commit 7df79d6 into datajoint:main Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pytest for multiple root data directories
5 participants