Update to permit multiple root dirs #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri-yatsenko
approved these changes
Nov 26, 2021
kabilar
requested changes
Dec 29, 2021
There was a problem hiding this comment.
Thanks @CBroz1. Good catch. Lets use find_full_path from element-data-loader.utils. In this pull request, could you please also set up the ephys module to use dict_to_uuid and find_root_directory from element-data-loader.utils? And then we can remove these functions from the __init__.py.
|
I just actually realized that my suggested changes are in pull request #35. Could you please review this pull request first? |
Unfortunately, I wasn't aware of this PR when you and I discussed me taking on this multiple root task. The changes there are more comprehensive and cover all features present here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
ephys.py, multiple instances of grabbing the full session path withfind_full_pathfrom the element's__init__.py. See parallel PR forworkflow-array-ephysfor the same functionality. Notably,workflownow depends on the samefind_full_pathfromelement-data-loader.utils- should both reference the same instance offind-full-pathor should they maintain independent versions of the same function?