-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup docstrings, add notebook render #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kabilar Gunalan <[email protected]>
CBroz1
requested review from
sidhulyalkar
and removed request for
kushalbakshi
January 13, 2023 18:01
This was
linked to
issues
Jan 13, 2023
Closed
this supports backward compability with typing
JaerongA
reviewed
Jan 18, 2023
JaerongA
reviewed
Jan 18, 2023
fix: 🐛 import from __future__ to support backward compatibility
Co-authored-by: JaerongA <[email protected]>
Thanks @JaerongA for looking into typing compatibility. Thanks for running the pytests with the previous |
JaerongA
approved these changes
Jan 19, 2023
ttngu207
approved these changes
Jan 19, 2023
sidhulyalkar
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission checklist
Files changed
prior to selectingCreate Pull Request
.Submission details
Please review commits individually. Linting edits have been separated from substantive edits by commit
In this pull request, I make the following changes:
cspell.json
- add permitted words for vscode spell extensiondocs/mkdocs.yaml
- spellcheck notesdocs/src/concepts
- remove singular bullets, add spaces before/after headingsscehma
->schema
element_array_ephys/plotting/qc.py
- various comment/docstring misspellings.markdownlint.yaml
- config for markdown lintingdocs/src/concepts.md
- hard wrap, and change citation to footnotecode_of_conduct
- ensure first line is heading 1docs/src/index.md
,docs/src/citation.md
,contributing
,changelog
gitignore
- add ignore of notebookstutorials.md
->tutorials/index.md
- add summary of each notebook and links to other resourcesdocs/src/api/make_pages.py
- migrate workflow download to docker composedocs/mkdocs.yaml
- add page for each notebookdocs/src/citation.md
- change link to new tutorials indexdocs/.docker/pip_requirements
- add jupyter extensionnwb_conversion_tools
->neuroconv
extras_require
installation options for nwb and dev workelement_interface
not in requirements #66docs/docker-compose.yaml
- add mkdocs log file (gitignored) - tee pulls copy to log without silencing stdoutdocs/mkdocs.yaml
- add mkdocstrings params so api renders in file order, not alphabeticallydocs/mkdocs.yaml
- add footnotes extension for concepts pagedocs/src/changelog
- refresh as soft link