Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element_interface not in requirements #66

Closed
sneakers-the-rat opened this issue May 6, 2022 · 2 comments · Fixed by #124
Closed

element_interface not in requirements #66

sneakers-the-rat opened this issue May 6, 2022 · 2 comments · Fixed by #124
Milestone

Comments

@sneakers-the-rat
Copy link

element_interface is imported from:

from element_interface.utils import find_root_directory, find_full_path, dict_to_uuid

but it's not in the requirements:
https://github.com/datajoint/element-array-ephys/blob/main/requirements.txt

so the module can't be imported.

@kabilar
Copy link
Collaborator

kabilar commented May 6, 2022

Thanks for the report @sneakers-the-rat. We opted not to keep element-interface in the requirements.txt because element-interface is used to install third-party packages, some of which are not on PyPI. From what I understand, all packages within the requirements.txt or setup.py must be published to PyPI in order for the package of interest to be published to PyPI. Please let us know if you have any suggestions as we are trying to find a cleaner way of setting up these dependencies.

@sneakers-the-rat
Copy link
Author

sneakers-the-rat commented May 7, 2022

you can require something from git in a requirements.txt file!

package-name @ git+https://github.com/whatever/repo@branchname

see https://pip.pypa.io/en/stable/topics/vcs-support/

I have several packages on PyPI that have git dependencies, so it's definitely allowed! for example: https://github.com/wehr-lab/autopilot/blob/637064da3d10e9eeb186483827c8b7dadaa2f356/pyproject.toml#L55

edit: coming back embarassed to say that while i have been publishing packages on pypi that have git dependencies for awhile, it apparently was only because of them being implicitly in a requirements.txt file (and thus not in the wheel's metadata), and when packaged correctly you are right that you can't put them up there! 🤦

@CBroz1 CBroz1 added this to the 2023Q2+ milestone Jun 15, 2022
@CBroz1 CBroz1 linked a pull request Jan 13, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants