Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element_interface imported but not in requirements #21

Closed
sneakers-the-rat opened this issue May 6, 2022 · 2 comments · Fixed by #19
Closed

element_interface imported but not in requirements #21

sneakers-the-rat opened this issue May 6, 2022 · 2 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@sneakers-the-rat
Copy link

Bug Report

Description

element_interface is imported:

from element_interface.utils import find_full_path, find_root_directory

but not in requirements.txt, so the package cannot be imported.

duplicate of datajoint/element-array-ephys#66

@sneakers-the-rat sneakers-the-rat added the bug Something isn't working label May 6, 2022
CBroz1 added a commit to CBroz1/element-deeplabcut that referenced this issue May 6, 2022
@CBroz1 CBroz1 linked a pull request May 6, 2022 that will close this issue
@kabilar
Copy link
Collaborator

kabilar commented May 6, 2022

Thanks for the report @sneakers-the-rat. We opted not to keep element-interface in the requirements.txt because element-interface is used to install third-party packages, some of which are not on PyPI. From what I understand, all packages within the requirements.txt or setup.py must be published to PyPI in order for the package of interest to be published to PyPI. Please let us know if you have any suggestions as we are trying to find a cleaner way of setting up these dependencies.

@sneakers-the-rat
Copy link
Author

you can require something from git in a requirements.txt file!

package-name @ git+https://github.com/whatever/repo@branchname

see https://pip.pypa.io/en/stable/topics/vcs-support/

I have several packages on PyPI that have git dependencies, so it's definitely allowed! for example: https://github.com/wehr-lab/autopilot/blob/637064da3d10e9eeb186483827c8b7dadaa2f356/pyproject.toml#L55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants