chore(ingest/tableau): miscellaneous cleanup refractor #8417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
github-actions
bot
added
the
ingestion
asikowitz
reviewed
Jul 14, 2023
| schema = table.get(tableau_constant.SCHEMA, "") | ||
| table_name = table.get(tableau_constant.NAME, "") | ||
| full_name = table.get(tableau_constant.FULL_NAME, "") | ||
| schema = table.get(tableau_constant.SCHEMA) or "" |
There was a problem hiding this comment.
Is it possible table[NAME] == None? Just curious on the reason for these changes, overall I'm happy with them
| tableau_constant.EXTRACT_LAST_UPDATE_TIME, "" | ||
| ) | ||
| or "", | ||
| tableau_constant.TYPE: datasource.get(tableau_constant.TYPE_NAME, ""), |
There was a problem hiding this comment.
We're fetching key TYPE_NAME but only TYPE in the new code
There was a problem hiding this comment.
nice catch.
So it fetches the key named "__typename" from dictionary and adds it to custom props with key "type". I believe, it is okay to keep __typename as key in custom dict OR remove this key entirely , as the type of datasource is captured in subtype.
asikowitz
approved these changes
Jul 25, 2023
|
Merging as this shouldn't affect smoke tests and it seems like the failures were due to the tests taking too long... gonna try one more time first |
asikowitz
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist