fix(ingest/tableau): graceful handling of get all datasources failure… #8406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurinehate
force-pushed
the
tableau_handle_datasources_exc
branch
from
652fed1
to
47ea73c
Compare
mayurinehate
requested review from
hsheth2,
treff7es and
asikowitz
and removed request for
treff7es
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Jul 12, 2023
| ) | ||
| continue | ||
| self.datasource_project_map[ds.id] = ds.project_id | ||
| self.report.get_all_datasources_query_failed = False |
There was a problem hiding this comment.
This looks like a no-op. Either way we should set the default to None or just remove this statement
| @@ -1304,6 +1331,30 @@ def _get_published_datasource_project_luid(self, ds): | |||
|
|
|||
| return None | |||
|
|
|||
| def _query_published_datasource_for_project_luid(self, ds: dict) -> None: | |||
There was a problem hiding this comment.
Can we pass in ds[LUID] rather than ds here?
There was a problem hiding this comment.
addressed in followup PR
Comment on lines
+1674
to
+1676
| container_key = self._get_datasource_container_key( | ||
| datasource, workbook, is_embedded_ds | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, add fallback
Also adds TableauSourceReport to track failures when parsing tableau response.
Checklist