Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: False alarm for overlapping pool with three domains in one EPG #162

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

takishida
Copy link
Collaborator

When there are three (or more) domains associated to an EPG, the overlapping VLAN pool check may flag it as FAIL - OUTAGE WARNING!! or MANUAL CHECK REQUIRED incorrectly.

Example:

+ EPG 1 (VLAN 10)
    +--- Domain 1 --> VLAN Pool A (VLAN 10-20)
    +--- Domain 2 --> VLAN Pool A (VLAN 10-20)
    +--- Domain 3 --> VLAN Pool B (VLAN 15-20)

As shown in the example above, three domains (Domain 1, 2 and 3) are associated to EPG 1 which is using VLAN 10. Domain 1 and 2 are using the same VLAN Pool A while Domain 3 is using VLAN Pool B.

In this case, there are overlapping VLAN IDs (15-20) between these domains, in other words between VLAN Pool A and B. However, the VLAN used for this EPG is 10 which is only in VLAN Pool A, which is used by Domain 1 and 2.

The current logic flags this as FAIL - OUTAGE WARNING!! or MANUAL CHECK REQUIRED incorrectly because there are more than one domain for VLAN 10 in EPG 1 which has overlapping VLAN ranges even though the overlap is not between those two domains for VLAN 10.

This PR fixes this issue by correctly checking the identity of VLAN Pools behind the domains.

Cosmetic enhancement

It also has a cosmetic enhancement. The check currently repeats the same VLAN pool name for each domain. In the new output, domains using the same VLAN Pool is displayed at once.

Current:

[Check  1/1] Overlapping VLAN Pools...                                                                            FAIL - OUTAGE WARNING!!
  Tenant  AP   EPG   Node  Port       VLAN Scope  VLAN ID  VLAN Pools (Domains)                                      Impact
  ------  --   ---   ----  ----       ----------  -------  --------------------                                      ------
  TN1     AP1  EPG1  101   IFPG_VPC1  global      2011     VLANPool2(PHYDOM3),VLANPool1(PHYDOM1),VLANPool1(PHYDOM2)  Outage
  TN1     AP1  EPG1  102   IFPG_VPC1  global      2011     VLANPool2(PHYDOM3),VLANPool1(PHYDOM1),VLANPool1(PHYDOM2)  Outage

New:

[Check  1/1] Overlapping VLAN Pools...                                                                            FAIL - OUTAGE WARNING!!
  Tenant  AP   EPG   Node  Port       VLAN Scope  VLAN ID  VLAN Pools (Domains)                            Impact
  ------  --   ---   ----  ----       ----------  -------  --------------------                            ------
  TN1     AP1  EPG1  101   IFPG_VPC1  global      2011     VLANPool2(PHYDOM3), VLANPool1(PHYDOM1,PHYDOM2)  Outage
  TN1     AP1  EPG1  102   IFPG_VPC1  global      2011     VLANPool2(PHYDOM3), VLANPool1(PHYDOM1,PHYDOM2)  Outage

@monrog2 monrog2 linked an issue Sep 17, 2024 that may be closed by this pull request
@monrog2 monrog2 merged commit 02edf60 into master Sep 17, 2024
3 checks passed
@monrog2 monrog2 deleted the overlapping_vlan_3_domains branch September 17, 2024 14:52
takishida added a commit that referenced this pull request Nov 7, 2024
`vnid_mismatch_check` was added to complement
`overlapping_vlan_pools_check`. Given the recent update (#155, #162),
`vnid_mismatch_check` became redundant, and it was decided to remove
this check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping VLAN pool check result does not match true expected result
2 participants