fix: False alarm for overlapping pool with three domains in one EPG #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are three (or more) domains associated to an EPG, the overlapping VLAN pool check may flag it as
FAIL - OUTAGE WARNING!!
orMANUAL CHECK REQUIRED
incorrectly.Example:
As shown in the example above, three domains (Domain 1, 2 and 3) are associated to EPG 1 which is using VLAN 10. Domain 1 and 2 are using the same VLAN Pool A while Domain 3 is using VLAN Pool B.
In this case, there are overlapping VLAN IDs (15-20) between these domains, in other words between VLAN Pool A and B. However, the VLAN used for this EPG is 10 which is only in VLAN Pool A, which is used by Domain 1 and 2.
The current logic flags this as
FAIL - OUTAGE WARNING!!
orMANUAL CHECK REQUIRED
incorrectly because there are more than one domain for VLAN 10 in EPG 1 which has overlapping VLAN ranges even though the overlap is not between those two domains for VLAN 10.This PR fixes this issue by correctly checking the identity of VLAN Pools behind the domains.
Cosmetic enhancement
It also has a cosmetic enhancement. The check currently repeats the same VLAN pool name for each domain. In the new output, domains using the same VLAN Pool is displayed at once.
Current:
New: