Remove vnid_mismatch_check #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vnid_mismatch_checkwas added to complementoverlapping_vlan_pools_check.Given the recent update (#155, #162),
vnid_mismatch_checkbecame redundant, and it has a risk of raising a false alarm (see below for details). Thus, it was decided to be removed.An example of false alarm from
vnid_mismatch_check:Note that these two switches are not vPC pair.
This is alerted by
vnid_mismatch_checkbecause VLAN 10 on node 101 and 105 are assigned a different VNID from respective VLAN pools. However, it's expected and will not cause any issues with an upgrade because the VNID for each node is deterministic and will always be the same even after the upgrade. See the "Example: good only for a specific use case" in https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#overlapping-vlan-pool for details.