Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TF provider to 1.58.0 #1900

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Upgrade TF provider to 1.58.0 #1900

merged 2 commits into from
Nov 14, 2024

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Nov 13, 2024

Changes

Notable changes:

  • Adds support for restart_window for pipelines.
  • Fix drift for pipelines where catalog contains uppercase characters.
  • Better error message if single-node job clusters are incorrectly configured.

See:

Tests

Integration tests pass.

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 1900
  • Commit SHA: 93c569a5d3428d2ad0f1d5a1ff9002a72a4783e2

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11837584085

@pietern
Copy link
Contributor Author

pietern commented Nov 14, 2024

Beware: this bump does NOT include the proposed changes to the quality_monitor resource.

The TF provider implementation was changed to use the plugin framework for this resource, and since then, it no longer includes whether a nested object is a single block (list with max 1 item) or multiple blocks (list with any number of items).

We use the former condition to inline a nested object as a pointer type. Without this condition, we must embed it as a slice type, and we can no longer convert between our representation and the TF representation.

I manually confirmed that we can continue to use the nester object as a pointer type. TF performs the conversion (I think) and interprets the nested object correctly as a list of size 1.

@pietern pietern merged commit 21d2788 into main Nov 14, 2024
9 checks passed
@pietern pietern deleted the tf-bump branch November 14, 2024 13:00
andrewnester added a commit that referenced this pull request Nov 14, 2024
Bundles:
 * Do not execute build on bundle destroy ([#1882](#1882)).
 * Add support for non-Python ipynb notebooks to DABs ([#1827](#1827)).

API Changes:
 * Added `databricks credentials` command group.
 * Changed `databricks genie execute-message-query` command to type `databricks genie execute-message-query` command.
 * Changed `databricks lakeview create` command with new required argument order.
 * Added `databricks aibi-dashboard-embedding-access-policy` command group.
 * Added `databricks aibi-dashboard-embedding-approved-domains` command group.
 * Removed `databricks clean-rooms` command group.

OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07)
Dependency updates:
 * Upgrade TF provider to 1.58.0 ([#1900](#1900)).
 * Bump golang.org/x/sync from 0.8.0 to 0.9.0 ([#1892](#1892)).
 * Bump golang.org/x/text from 0.19.0 to 0.20.0 ([#1893](#1893)).
 * Bump golang.org/x/mod from 0.21.0 to 0.22.0 ([#1895](#1895)).
 * Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0 ([#1894](#1894)).
 * Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0 ([#1878](#1878)).
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2024
Bundles:
* Do not execute build on bundle destroy
([#1882](#1882)).
* Add support for non-Python ipynb notebooks to DABs
([#1827](#1827)).

API Changes:
 * Added `databricks credentials` command group.
* Changed `databricks lakeview create` command with new required
argument order.

OpenAPI commit d25296d2f4aa7bd6195c816fdf82e0f960f775da (2024-11-07)
Dependency updates:
* Upgrade TF provider to 1.58.0
([#1900](#1900)).
* Bump golang.org/x/sync from 0.8.0 to 0.9.0
([#1892](#1892)).
* Bump golang.org/x/text from 0.19.0 to 0.20.0
([#1893](#1893)).
* Bump golang.org/x/mod from 0.21.0 to 0.22.0
([#1895](#1895)).
* Bump golang.org/x/oauth2 from 0.23.0 to 0.24.0
([#1894](#1894)).
* Bump github.com/databricks/databricks-sdk-go from 0.49.0 to 0.51.0
([#1878](#1878)).
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2024
## Changes

This field was special-cased in #1307 because it's not part of the JSON
payload in the SDK struct.

This approach, while pragmatic, meant it didn't show up in the JSON
schema. While debugging an issue with quality monitors in #1900, I
couldn't figure out why I was getting schema errors on this field, or
how it was passed through to the TF representation. This commit removes
the special case and makes it behave like everything else.

## Tests

* Unit tests pass.
* Confirmed that the updated schema failed validation before this
change.
pietern added a commit that referenced this pull request Dec 5, 2024
## Changes

Notable changes:
* Fixes dashboard deployment if it was trashed out-of-band.
* Removes client-side validation for single-node cluster configuration
(also see #1546).

Beware: for the same reason as in #1900, this excludes the changes for
the quality monitor resource.

## Tests

Integration tests pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants