Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade TF provider to 1.61.0 #2011

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Upgrade TF provider to 1.61.0 #2011

merged 3 commits into from
Dec 13, 2024

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Dec 13, 2024 •
edited
Loading

Changes

Upgraded to TF provider 1.61.0

New Features and Improvements

@andrewnester andrewnester requested a review from pietern December 13, 2024 13:50
pietern
pietern reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include a short summary of the changes in the PR.

Did you confirm the apps PR works with this one?

bundle/internal/tf/codegen/generator/walker.go Outdated Show resolved Hide resolved
bundle/internal/tf/schema/root.go Outdated Show resolved Hide resolved
mgyucht
mgyucht reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but I would defer to @pietern.

@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2011
  • Commit SHA: 2300a5755ed64498a3a556a45196cdb53c1e9732

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12317381321

@andrewnester andrewnester requested a review from pietern December 13, 2024 14:29
@andrewnester
Copy link
Contributor Author

@pietern confirmed it works, just needed to remove the resources -> resource rename when doing TF conversion

@pietern pietern changed the title Upgraded to TF provider 1.61.0 Upgrade TF provider to 1.61.0 Dec 13, 2024
pietern
pietern approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you update the PR summary before merging?

@andrewnester andrewnester added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 58dfa70 Dec 13, 2024
11 checks passed
@andrewnester andrewnester deleted the tf-provider-1.61.0 branch December 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht left review comments

@pietern pietern pietern approved these changes

@denik denik Awaiting requested review from denik

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewnester @eng-dev-ecosystem-bot @pietern @mgyucht